From 793b0978199cae4d4882a63d55621cb21b40a2d9 Mon Sep 17 00:00:00 2001
From: Alex 'AdUser' Z <ad_user@linuxdv.org>
Date: Thu, 20 Nov 2014 14:27:57 +1000
Subject: [PATCH] * LDV::LDAP : reorder functions

---
 lib/LDV/LDAP.pm | 43 ++++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/lib/LDV/LDAP.pm b/lib/LDV/LDAP.pm
index 87411af..c60fbaf 100644
--- a/lib/LDV/LDAP.pm
+++ b/lib/LDV/LDAP.pm
@@ -62,28 +62,8 @@ sub create {
     sn  => 'just',
     cn  => 'created',
   ]);
-  return $result->error if ($result->code);
   $conn->unbind;
-  return;
-}
-
-sub update {
-  my ($self, $uid, $attrs) = @_;
-  return "Attrs isn't HASH"
-    if (ref($attrs) ne 'HASH');
-
-  my $conn   = $self->_connect();
-  $uid = $self->_escape($uid);
-
-  my $data = $self->get($uid);
-  return "No such user"
-    unless ($data);
-
-  my $dn = sprintf "uid=%s,%s", $uid, $self->{userbase};
-  foreach my $key (keys($attrs)) {
-    ...
-  }
-
+  return $result->error if ($result->code);
   return;
 }
 
@@ -94,6 +74,7 @@ sub delete {
   my $dn = sprintf "uid=%s,%s", $uid, $self->{userbase};
   my $result = $conn->delete($dn);
   $conn->unbind;
+  return $result->error if ($result->code);
   return;
 }
 
@@ -115,4 +96,24 @@ sub get {
   return $data;
 }
 
+sub update {
+  my ($self, $uid, $attrs) = @_;
+  return "Attrs isn't HASH"
+    if (ref($attrs) ne 'HASH');
+
+  my $conn   = $self->_connect();
+  $uid = $self->_escape($uid);
+
+  my $data = $self->get($uid);
+  return "No such user"
+    unless ($data);
+
+  my $dn = sprintf "uid=%s,%s", $uid, $self->{userbase};
+  foreach my $key (keys($attrs)) {
+    ...
+  }
+
+  return;
+}
+
 1;