From 53a775aedcc30716d2d6e6ad406a9d4350fe761e Mon Sep 17 00:00:00 2001
From: Alex 'AdUser' Z <ad_user@runbox.com>
Date: Fri, 30 Dec 2016 00:32:53 +1000
Subject: [PATCH] * use simdb_urec_t instead direct access by offsets

---
 src/database.c | 28 ++++++++++++++--------------
 src/sample.c   | 13 ++++++++-----
 2 files changed, 22 insertions(+), 19 deletions(-)

diff --git a/src/database.c b/src/database.c
index 6130810..c6b727d 100644
--- a/src/database.c
+++ b/src/database.c
@@ -257,10 +257,10 @@ simdb_search(simdb_t        * const db,
 {
   simdb_block_t blk;
   simdb_match_t match;
+  simdb_urec_t *rec;
   const int blk_size = 4096;
   uint64_t found = 0;
   unsigned int i = 0;
-  unsigned char *p = NULL;
   float ratio_s = 0.0; /* source */
   float ratio_t = 0.0; /* tested */
   int ret = 0;
@@ -289,16 +289,16 @@ simdb_search(simdb_t        * const db,
   CALLOC(*matches, search->limit, sizeof(simdb_match_t));
 
   while (simdb_block_read(db, &blk) > 0) {
-    p = blk.data;
-    for (i = 0; i < blk.records; i++, p += SIMDB_REC_LEN) {
-      if (*(p + REC_OFF_RU) == 0x0)
+    rec = (simdb_urec_t *) blk.data;
+    for (i = 0; i < blk.records; i++, rec++) {
+      if (rec->used == 0x0)
         continue; /* record missing */
 
       match.diff_ratio  = 0.0;
       match.diff_bitmap = 0.0;
 
       /* - compare ratio - cheap */
-      if (ratio_s > 0.0 && (ratio_t = simdb_record_ratio((simdb_urec_t *) p)) > 0.0) {
+      if (ratio_s > 0.0 && (ratio_t = simdb_record_ratio(rec)) > 0.0) {
         match.diff_ratio  =  ratio_s - ratio_t;
         match.diff_ratio *= (ratio_s > ratio_t) ? 1.0 : -1.0;
         if (match.diff_ratio > search->maxdiff_ratio)
@@ -308,7 +308,7 @@ simdb_search(simdb_t        * const db,
       }
 
       /* - compare bitmap - more expensive */
-      match.diff_bitmap = simdb_bitmap_compare(p + REC_OFF_BM, sample->data + REC_OFF_BM) / SIMDB_BITMAP_BITS;
+      match.diff_bitmap = simdb_bitmap_compare(rec->bitmap, ((simdb_urec_t *) sample)->bitmap) / SIMDB_BITMAP_BITS;
       if (match.diff_bitmap > search->maxdiff_bitmap)
         continue;
 
@@ -334,7 +334,7 @@ simdb_usage_map(simdb_t * const db,
   const int blk_size = 4096;
   simdb_block_t blk;
   uint64_t records;
-  unsigned char *r; /* mnemonics : block, record */
+  simdb_urec_t *r; /* mnemonics : block, record */
   char *m = NULL;   /* mnemonics : map */
 
   memset(&blk, 0x0, sizeof(simdb_block_t));
@@ -347,9 +347,9 @@ simdb_usage_map(simdb_t * const db,
   blk.records = blk_size;
 
   while (simdb_block_read(db, &blk) > 0) {
-    r = blk.data;
-    for (unsigned int i = 0;  i < blk.records;  i++, m++, r += SIMDB_REC_LEN) {
-      *m = (r[REC_OFF_RU] == 0xFF) ? CHAR_USED : CHAR_NONE;
+    r = (simdb_urec_t *) blk.data;
+    for (unsigned int i = 0; i < blk.records; i++, m++, r++) {
+      *m = (r->used == 0xFF) ? CHAR_USED : CHAR_NONE;
     }
     blk.start += blk_size;
   }
@@ -364,7 +364,7 @@ simdb_usage_slice(simdb_t   * const db,
                   uint64_t  offset,
                   uint16_t  limit) {
   simdb_block_t blk;
-  unsigned char *r; /* mnemonics : block, record */
+  simdb_urec_t *r;  /* mnemonics : block, record */
   char *m = NULL;   /* mnemonics : map */
 
   memset(&blk, 0x0, sizeof(simdb_block_t));
@@ -375,9 +375,9 @@ simdb_usage_slice(simdb_t   * const db,
   blk.records = limit;
 
   limit = simdb_block_read(db, &blk);
-  r = blk.data;
-  for (uint16_t i = 0;  i < blk.records;  i++, m++, r += SIMDB_REC_LEN) {
-    *m = (r[REC_OFF_RU] == 0xFF) ? CHAR_USED : CHAR_NONE;
+  r = (simdb_urec_t *) blk.data;
+  for (uint16_t i = 0;  i < blk.records;  i++, m++, r++) {
+    *m = (r->used == 0xFF) ? CHAR_USED : CHAR_NONE;
   }
 
   return limit;
diff --git a/src/sample.c b/src/sample.c
index fffeaf8..ff8dfc6 100644
--- a/src/sample.c
+++ b/src/sample.c
@@ -1,6 +1,7 @@
 #include "common.h"
 #include "bitmap.h"
 #include "simdb.h"
+#include "record.h"
 #include "sample.h"
 
 #include <wand/magick_wand.h>
@@ -82,12 +83,14 @@ simdb_sample(simdb_rec_t * const rec,
 #endif
 
   if (status == MagickPass) {
+    simdb_urec_t urec;
     assert(buf_size == SIMDB_BITMAP_SIZE);
-    memset(rec->data, 0x0, SIMDB_REC_LEN);
-    rec->data[REC_OFF_RU] = 0xFF;
-    memcpy(&rec->data[REC_OFF_IW], &w, sizeof(uint16_t));
-    memcpy(&rec->data[REC_OFF_IH], &h, sizeof(uint16_t));
-    memcpy(&rec->data[REC_OFF_BM], buf, SIMDB_BITMAP_SIZE);
+    memset(&urec, 0x0, sizeof(urec));
+    urec.used = 0xFF;
+    urec.image_w = w;
+    urec.image_h = h;
+    memcpy(urec.bitmap, buf, SIMDB_BITMAP_SIZE);
+    memcpy(rec->data, &urec, sizeof(rec->data));
   } else {
     description = MagickGetException(wand, &severity);
     fprintf(stderr, "%03d %.1024s\n", severity, description);