From 82808a1459ccdefb9f782ac86341dd8e608eda1d Mon Sep 17 00:00:00 2001
From: Alex 'AdUser' Z <ad_user@runbox.com>
Date: Wed, 21 Sep 2016 13:38:53 +1000
Subject: [PATCH] + f2b_cmd_append_arg()

---
 src/commands.c | 26 ++++++++++++++------------
 src/commands.h |  3 +++
 2 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/src/commands.c b/src/commands.c
index 1796808..16585dd 100644
--- a/src/commands.c
+++ b/src/commands.c
@@ -108,6 +108,14 @@ f2b_cmd_help() {
   return;
 }
 
+void
+f2b_cmd_append_arg(char *buf, size_t bufsize, const char *arg) {
+  assert(buf != NULL);
+  assert(arg != NULL);
+  strlcat(buf, arg,  bufsize);
+  strlcat(buf, "\n", bufsize);
+}
+
 /**
  * @brief Parse command from line
  * @param src  Line taken from user input
@@ -155,31 +163,25 @@ f2b_cmd_parse(const char *src, char *buf, size_t buflen) {
   buf[0] = '\0';
   if (strcmp(line, "jail") == 0 && tokenc > 1) {
     /* commands for jail */
-    strlcpy(buf, tokens[1], buflen);
-    strlcat(buf, "\n", buflen);
+    f2b_cmd_append_arg(buf, buflen, tokens[1]);
     if (tokenc == 3 && strcmp(tokens[2], "status") == 0) {
       return CMD_JAIL_STATUS;
     }
     if (tokenc == 5 && strcmp(tokens[2], "set") == 0) {
-      strlcat(buf, tokens[3], buflen);
-      strlcat(buf, "\n", buflen);
-      strlcat(buf, tokens[4], buflen);
-      strlcat(buf, "\n", buflen);
+      f2b_cmd_append_arg(buf, buflen, tokens[3]);
+      f2b_cmd_append_arg(buf, buflen, tokens[4]);
       return CMD_JAIL_SET;
     }
     if (tokenc == 5 && strcmp(tokens[2], "ip") == 0 && strcmp(tokens[3], "status") == 0) {
-      strlcat(buf, tokens[4], buflen);
-      strlcat(buf, "\n", buflen);
+      f2b_cmd_append_arg(buf, buflen, tokens[4]);
       return CMD_JAIL_IP_STATUS;
     }
     if (tokenc == 5 && strcmp(tokens[2], "ip") == 0 && strcmp(tokens[3], "ban") == 0) {
-      strlcat(buf, tokens[4], buflen);
-      strlcat(buf, "\n", buflen);
+      f2b_cmd_append_arg(buf, buflen, tokens[4]);
       return CMD_JAIL_IP_BAN;
     }
     if (tokenc == 5 && strcmp(tokens[2], "ip") == 0 && strcmp(tokens[3], "release") == 0) {
-      strlcat(buf, tokens[4], buflen);
-      strlcat(buf, "\n", buflen);
+      f2b_cmd_append_arg(buf, buflen, tokens[4]);
       return CMD_JAIL_IP_RELEASE;
     }
     if (tokenc == 4 && strcmp(tokens[2], "filter") == 0 && strcmp(tokens[3], "stats") == 0) {
diff --git a/src/commands.h b/src/commands.h
index 02996e5..842beb3 100644
--- a/src/commands.h
+++ b/src/commands.h
@@ -34,6 +34,9 @@ void f2b_cmd_help();
 enum f2b_cmd_type
 f2b_cmd_parse(const char *src, char *buf, size_t buflen);
 
+void
+f2b_cmd_append_arg(char *buf, size_t bufsize, const char *arg);
+
 bool
 f2b_cmd_check_argc(enum f2b_cmd_type type, int argc);